Adding windows-hpc-base-image #3663
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marosset The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/release-eng
| @@ -0,0 +1,121 @@ | |||
| Creative Commons Legal Code | |||
There was a problem hiding this comment.
Shouldn't we just use the repo's ASLv2?
the resulting image on top of the base will be largely ASLv2 anyhow.
There was a problem hiding this comment.
The equivalent image that gets published to MCR was released with the CC0 license - https://github.com/microsoft/windows-host-process-containers-base-image/blob/main/cc0-license.txt
There was a problem hiding this comment.
I mean we're going to build ASLv2 images with this, and CC0 is NOT on the CNCF approved list so we should not be using any CC0 images.
Are we using CC0 anywhere else ...?
https://github.com/cncf/foundation/blob/main/allowed-third-party-license-policy.md
There was a problem hiding this comment.
Also (I'm sure you saw mark) the script and Makefile need the boilerplate repo headers, and the automation will look for the apache license and fail if we use a different one.
There was a problem hiding this comment.
What's the reason behind releasing this under CC0? I have no particular feelings or thoughts but LF legal may have opinions here. (I've had to switch licenses for other projects based on their input).
There was a problem hiding this comment.
Can we rename this to cloudbuild.yaml to match other files in the repo?
| touch "$BUILD_DIR/layer/Files/Windows/System32/config/DEFAULT" | ||
| echo "" > "$BUILD_DIR/layer/Files/Windows/System32/config/DEFAULT" |
There was a problem hiding this comment.
I think the touch lines here are superfluous. Maybe drop them?
There was a problem hiding this comment.
I think I can remove the echo actually.
Let me verify and I'll remove one or the other
| To publish the image to a registry: | ||
|
|
||
| ```sh | ||
| REGISTRY=gcr.io/k8s-staging-releng VERSION=v0.1.0 make image_publish |
There was a problem hiding this comment.
The image image_publish target is missing from the makefile above.
There was a problem hiding this comment.
that should be image_push :-/ - i'll update
marosset
force-pushed
the
windows-hpc-base-image
branch
from
7af5a00
to
935ee79
Compare
|
@marosset: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
kubernetes/kubernetes#125297 is adding a Windows flavor to the kube-proxy image and there was some concern about basing the image on another image hosted at mcr.microsoft.com.
This PR adds a windows container base image that other images (like the Windows kube-proxy image) can be based on and is functionally equivalent to the image
mcr.microsoft.com/oss/kubernetes/windows-host-process-containers-base-image:v1.0.0but can be built and hosted in K8s community resoucesWhich issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?